Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat] update credentials #845

Merged
merged 4 commits into from
Feb 8, 2025
Merged

Conversation

d4mr
Copy link
Member

@d4mr d4mr commented Feb 8, 2025

PR-Codex overview

This PR focuses on enhancing the wallet credential management system by adding nullable properties, improving error handling, and introducing an update route for wallet credentials.

Detailed summary

  • isDefault and deletedAt properties made nullable.
  • Improved entitySecret validation description in create.ts.
  • Added updateWalletCredentialRoute to handle updates for wallet credentials.
  • Enhanced error handling in create.ts and update.ts.
  • Introduced update-wallet-credential.ts for updating wallet credentials logic.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

zeet-co bot commented Feb 8, 2025

We're building your pull request over on Zeet.
Click me for more info about your build and deployment.
Once built, this branch can be tested at: https://tw-unreal-demo-engine-vwn0-pb-do--201af1.engine-aws-usw2.zeet.app before merging 😉

@d4mr d4mr requested a review from arcoraven February 8, 2025 06:43
@d4mr d4mr changed the title update credential [feat] update credentials Feb 8, 2025
@d4mr d4mr merged commit 07d1d7d into main Feb 8, 2025
6 of 7 checks passed
@d4mr d4mr deleted the pb/do-not-autocreate-circle-entity-secret branch February 8, 2025 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant