credentials feature flag and sdk bump #844
Merged
+174
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We're building your pull request over on Zeet. |
arcoraven
reviewed
Feb 8, 2025
src/server/routes/system/health.ts
Outdated
| @@ -25,6 +26,7 @@ const ReplySchemaOk = Type.Object({ | |||
| Type.Literal("IP_ALLOWLIST"), | |||
| Type.Literal("HETEROGENEOUS_WALLET_TYPES"), | |||
| Type.Literal("SMART_BACKEND_WALLETS"), | |||
| Type.Literal("CREDENTIALS"), | |||
There was a problem hiding this comment.
Can you rename this to WALLET_CREDENTIALS to be clearer
arcoraven
reviewed
Feb 8, 2025
| @@ -30,6 +30,7 @@ import { MarketplaceOffersService } from './services/MarketplaceOffersService'; | |||
| import { PermissionsService } from './services/PermissionsService'; | |||
| import { RelayerService } from './services/RelayerService'; | |||
| import { TransactionService } from './services/TransactionService'; | |||
| import { WalletCredentialsService } from './services/WalletCredentialsService'; | |||
There was a problem hiding this comment.
Should the SDK folder be .gitignored?
arcoraven
approved these changes
Feb 8, 2025
zeet-co
bot
requested a deployment
to
pb/credentials-featureflag-and-sdk
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR-Codex overview
This PR primarily updates the version of the package and introduces a new
WalletCredentialsServicealong with enhancements to existing services and configuration options. It also improves type definitions and adds new features related to wallet credentials.Detailed summary
versioninsdk/package.jsonto0.0.19.sdk/src/services/WebhooksService.ts.WalletCredentialsServiceexport insdk/src/index.ts.src/server/routes/system/health.ts.sdk/src/services/ContractEventsService.ts.walletCredentialsproperty insdk/src/Engine.ts.sdk/src/services/ConfigurationService.ts.getAuthConfigurationandupdateAuthConfigurationmethods insdk/src/services/ConfigurationService.ts.WalletCredentialsServicewith methods for creating and retrieving wallet credentials insdk/src/services/WalletCredentialsService.ts.