fix: Cancel tx if populating a tx to retry fails #493
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We're building your pull request over on Zeet. |
farhanW3
added a commit
that referenced
this pull request
Apr 19, 2024
* CICD for beta-nightly image (#481) * Updated Packages + UserOp Confirmation flow updated (#479) * Updated Packages + UserOp Confirmation flow updated * wallets sdk updated * fix: missing querystring + description upd (#486) * Added querystring to fastify route (#487) * fix: reject deprecated chains (#488) * chore: Allow cancelling txs that already errored (#491) * chore: Allow cancelling txs that already errored * clean up response * naming * update cancelledAt * fix: Cancel tx if populating a tx to retry fails (#493) * fix: Cancel tx if populating a tx to retry fails * ensure cancel uses high enough gas * fix build * combine prepare + send flows again * updates to GH flow, to use branch (#484) * updates to GH flow, to use branch * removed prelease incorrect tag * upds * got back tag creation check * upds * comments updated * final upds to handle the flow * Updated to use release::create for CI/CD image build/push flow * Updates to GH workflow to not push to if not release not from main (#495) * feat(experimental): Keypair auth (#494) * reorganize helper file * wip * support keypair auth * fix unit tests * return error messages for keypair auth errors * Don't catch JsonWebToken errors * catch access token * move public keys to db * fix: add crud endpoints * wip * add algorithm * add feature envvar * handle each jwt type separately * rename * remove expiration limit * Fix: Deploy Published Contract Flow (#499) * Updated Deploy Published Contract Flow + ProcessTx * removed commented lines * Updates * chore: add updated template for the railway (#490) * chore: add updated template for the railway Signed-off-by: Waren Gonzaga <[email protected]> * chore: remove referral code Signed-off-by: Waren Gonzaga <[email protected]> --------- Signed-off-by: Waren Gonzaga <[email protected]> * Build fixes (#500) * Fix for Issue 502 (#505) * Added tx overrides for EOA + AA --------- Signed-off-by: Waren Gonzaga <[email protected]> Co-authored-by: Phillip Ho <[email protected]> Co-authored-by: Waren Gonzaga <[email protected]>
farhanW3
added a commit
that referenced
this pull request
Apr 19, 2024
* add gas to txOverrides * Update: Completed Tx-Override (#506) * CICD for beta-nightly image (#481) * Updated Packages + UserOp Confirmation flow updated (#479) * Updated Packages + UserOp Confirmation flow updated * wallets sdk updated * fix: missing querystring + description upd (#486) * Added querystring to fastify route (#487) * fix: reject deprecated chains (#488) * chore: Allow cancelling txs that already errored (#491) * chore: Allow cancelling txs that already errored * clean up response * naming * update cancelledAt * fix: Cancel tx if populating a tx to retry fails (#493) * fix: Cancel tx if populating a tx to retry fails * ensure cancel uses high enough gas * fix build * combine prepare + send flows again * updates to GH flow, to use branch (#484) * updates to GH flow, to use branch * removed prelease incorrect tag * upds * got back tag creation check * upds * comments updated * final upds to handle the flow * Updated to use release::create for CI/CD image build/push flow * Updates to GH workflow to not push to if not release not from main (#495) * feat(experimental): Keypair auth (#494) * reorganize helper file * wip * support keypair auth * fix unit tests * return error messages for keypair auth errors * Don't catch JsonWebToken errors * catch access token * move public keys to db * fix: add crud endpoints * wip * add algorithm * add feature envvar * handle each jwt type separately * rename * remove expiration limit * Fix: Deploy Published Contract Flow (#499) * Updated Deploy Published Contract Flow + ProcessTx * removed commented lines * Updates * chore: add updated template for the railway (#490) * chore: add updated template for the railway Signed-off-by: Waren Gonzaga <[email protected]> * chore: remove referral code Signed-off-by: Waren Gonzaga <[email protected]> --------- Signed-off-by: Waren Gonzaga <[email protected]> * Build fixes (#500) * Fix for Issue 502 (#505) * Added tx overrides for EOA + AA --------- Signed-off-by: Waren Gonzaga <[email protected]> Co-authored-by: Phillip Ho <[email protected]> Co-authored-by: Waren Gonzaga <[email protected]> * updates to help with better readability --------- Signed-off-by: Waren Gonzaga <[email protected]> Co-authored-by: farhanW3 <[email protected]> Co-authored-by: farhanW3 <[email protected]> Co-authored-by: Phillip Ho <[email protected]> Co-authored-by: Waren Gonzaga <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR-Codex overview
This PR updates transaction handling logic by refining status checks and improving cancellation processes.
Detailed summary