Skip to content

Commit

Permalink
fix: unused fields causing build to fail (#700)
Browse files Browse the repository at this point in the history
* fix: unused fields causing build to fail

* check build action

* small change to readme
  • Loading branch information
arcoraven authored Oct 3, 2024
1 parent 7cd575b commit 8992694
Show file tree
Hide file tree
Showing 4 changed files with 26 additions and 3 deletions.
24 changes: 24 additions & 0 deletions .github/workflows/check-build.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
name: Check Build

on: pull_request

jobs:
build:
runs-on: ubuntu-latest
steps:
- name: Checkout code
uses: actions/checkout@v3
with:
ref: ${{ github.ref }}

- name: Set up Node.js
uses: actions/setup-node@v3
with:
node-version: "18"
cache: "yarn"

- name: Install dependencies
run: yarn install

- name: Run build
run: yarn build
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ Engine is an open-source, backend HTTP server that provides a production-ready i
- 700+ transactions sent onchain per second (can fill up an EVM block!)
- Managed backend wallets (local, KMS)
- Contract calls and deployments ([all EVM blockchains](https://thirdweb.com/chainlist) + private subnets)
- Gas optimizations with retries
- Gas-optimized retries, gas ceilings, and timeouts
- Smart account support with session tokens
- Gasless transactions with relayers
- Wallet and contract webhooks
Expand Down
2 changes: 1 addition & 1 deletion src/server/schemas/transaction/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -264,7 +264,7 @@ export const toTransactionSchema = (
if (transaction.status === "sent") {
return transaction.gasPrice?.toString() ?? null;
}
return transaction.overrides?.gasPrice?.toString() ?? null;
return null;
};

const resolveMaxFeePerGas = (): string | null => {
Expand Down
1 change: 0 additions & 1 deletion src/worker/tasks/migratePostgresTransactionsWorker.ts
Original file line number Diff line number Diff line change
Expand Up @@ -209,7 +209,6 @@ const toQueuedTransaction = (row: Transactions): QueuedTransaction => {

overrides: {
gas: maybeBigInt(row.gasLimit ?? undefined),
gasPrice: maybeBigInt(row.gasPrice ?? undefined),
maxFeePerGas: maybeBigInt(row.maxFeePerGas ?? undefined),
maxPriorityFeePerGas: maybeBigInt(row.maxPriorityFeePerGas ?? undefined),
},
Expand Down

0 comments on commit 8992694

Please sign in to comment.