Skip to content

Commit

Permalink
updates to GH flow, to use branch (#484)
Browse files Browse the repository at this point in the history
* updates to GH flow, to use branch

* removed prelease incorrect tag

* upds

* got back tag creation check

* upds

* comments updated

* final upds to handle the flow

* Updated to use release::create for CI/CD image build/push flow
  • Loading branch information
farhanW3 authored Apr 11, 2024
1 parent 4a97c7a commit 8305d06
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 48 deletions.
43 changes: 0 additions & 43 deletions .github/workflows/beta.yml

This file was deleted.

13 changes: 8 additions & 5 deletions .github/workflows/tagBasedImageBuild.yml
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
name: Tag Based Image Build

on:
create: # This listens to create events, which includes tag creations
release:
types: [created] # This listens to release creation events

jobs:
buildImageForNewTag:
if: startsWith(github.ref, 'refs/tags/') # Only run this job when a tag is created
runs-on: ubuntu-latest

steps:
Expand All @@ -17,6 +17,9 @@ jobs:

- name: Checkout code
uses: actions/checkout@v2
with:
# Fetches the branch at which the release was made
ref: ${{ github.event.release.target_commitish }}

- name: Set up Docker Buildx
uses: docker/setup-buildx-action@v1
Expand All @@ -35,10 +38,10 @@ jobs:
platforms: linux/amd64,linux/arm64
push: true
tags: |
thirdweb/engine:${{ github.ref_name }}
thirdweb/engine:latest
thirdweb/engine:${{ github.event.release.tag_name }}
${{ github.event.release.target_commitish == 'main' && 'thirdweb/engine:latest' }}
build-args: |
ENGINE_VERSION=${{ github.ref_name }}
ENGINE_VERSION=${{ github.event.release.tag_name }}
- name: Check Disk Space After Build
run: df -h

0 comments on commit 8305d06

Please sign in to comment.