Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ThirdwebInsight.GetTransactions API #134

Merged
merged 1 commit into from
Feb 21, 2025

Conversation

0xFirekeeper
Copy link
Member

@0xFirekeeper 0xFirekeeper commented Feb 21, 2025

Closes TOOL-3501


PR-Codex overview

This PR focuses on enhancing the Thirdweb library by adding transaction fetching capabilities and extending the Token_ERC721 class with a TokenId property. It introduces a new Transaction class and updates the GetTransactions method to support various filters.

Detailed summary

  • Updated Thirdweb.Console/Program.cs to uncomment the creation of ThirdwebInsight.
  • Added TokenId property to Token_ERC721 class.
  • Introduced a new Transaction class with multiple properties including ChainId, BlockNumber, and Hash.
  • Implemented GetTransactions method in ThirdwebInsight for fetching transactions with optional filters.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

linear bot commented Feb 21, 2025

@0xFirekeeper 0xFirekeeper merged commit 14b53f5 into main Feb 21, 2025
3 checks passed
@0xFirekeeper 0xFirekeeper deleted the firekeeper/insight-transactions branch February 21, 2025 22:49
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 75 lines in your changes missing coverage. Please review.

Please upload report for BASE (main@5beb93e). Learn more about missing BASE report.
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
Thirdweb/Thirdweb.Indexer/ThirdwebInsight.cs 0.00% 45 Missing ⚠️
Thirdweb/Thirdweb.Indexer/ThirdwebInsight.Types.cs 0.00% 30 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #134   +/-   ##
=======================================
  Coverage        ?   66.29%           
=======================================
  Files           ?       37           
  Lines           ?     5747           
  Branches        ?      748           
=======================================
  Hits            ?     3810           
  Misses          ?     1761           
  Partials        ?      176           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants