Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chain metadata fetching util int -> BigInteger #132

Merged
merged 1 commit into from
Feb 20, 2025

Conversation

0xFirekeeper
Copy link
Member

@0xFirekeeper 0xFirekeeper commented Feb 20, 2025

Closes TOOL-3489


PR-Codex overview

This PR updates the ThirdwebChainData class in the Thirdweb.Utils namespace to use BigInteger for ChainId and NetworkId properties instead of int, allowing for larger numerical values.

Detailed summary

  • Changed the type of ChainId from int to BigInteger.
  • Changed the type of NetworkId from int to BigInteger.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

linear bot commented Feb 20, 2025

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.69%. Comparing base (0ba0ee9) to head (46dc2f5).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #132   +/-   ##
=======================================
  Coverage   72.69%   72.69%           
=======================================
  Files          34       34           
  Lines        5233     5233           
  Branches      693      693           
=======================================
  Hits         3804     3804           
  Misses       1254     1254           
  Partials      175      175           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@0xFirekeeper 0xFirekeeper merged commit 869e48c into main Feb 20, 2025
3 checks passed
@0xFirekeeper 0xFirekeeper deleted the firekeeper/chain-metadata-update branch February 20, 2025 23:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants