Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to match new rotating secret key model #130

Closed
wants to merge 1 commit into from
Closed

Update to match new rotating secret key model #130

wants to merge 1 commit into from

Conversation

0xFirekeeper
Copy link
Member

@0xFirekeeper 0xFirekeeper commented Feb 12, 2025 •
edited by pr-codex bot
Loading

Closes TOOL-3391

PR-Codex overview

This PR focuses on refactoring the handling of ClientId and SecretKey in the ThirdwebClient, removing the computation of ClientId from SecretKey and adjusting related tests.

Detailed summary

  • Removed the ComputeClientIdFromSecretKey method from Utils.
  • Modified ThirdwebClient to set ClientId based on provided clientId instead of computing it from secretKey.
  • Updated tests to reflect changes in ClientId initialization and assertions.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@0xFirekeeper 0xFirekeeper requested a review from jnsdls February 12, 2025 20:57
@linear Linear
Copy link

linear bot commented Feb 12, 2025

TOOL-3391 Secret key v2

@0xFirekeeper 0xFirekeeper deleted the firekeeper/secret-v2 branch February 13, 2025 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jnsdls jnsdls Awaiting requested review from jnsdls

Assignees
No one assigned
Labels
DO NOT MERGE
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@0xFirekeeper