Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify AWS Date Override Behavior #121

Merged
merged 2 commits into from
Jan 10, 2025
Merged

Conversation

0xFirekeeper
Copy link
Member

@0xFirekeeper 0xFirekeeper commented Jan 10, 2025

Fixes TOOL-3020


PR-Codex overview

This PR focuses on refactoring the GenerateDataKey and InvokeLambdaWithTemporaryCredentialsAsync methods in the AWS.cs file to improve code structure and reduce redundancy by introducing a new method PostAwsRequestWithDateOverride.

Detailed summary

  • Removed the dateOverride parameter from GenerateDataKey.
  • Introduced requestBodyString and extraHeaders for better readability.
  • Replaced repetitive code with PostAwsRequestWithDateOverride.
  • Enhanced error handling for AWS requests.
  • Updated the signature generation logic to be more flexible.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

linear bot commented Jan 10, 2025

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.68%. Comparing base (e3a9e72) to head (0602127).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #121      +/-   ##
==========================================
- Coverage   76.76%   76.68%   -0.09%     
==========================================
  Files          28       28              
  Lines        4799     4799              
  Branches      665      665              
==========================================
- Hits         3684     3680       -4     
- Misses        942      945       +3     
- Partials      173      174       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@0xFirekeeper 0xFirekeeper merged commit 3a782c8 into main Jan 10, 2025
1 check passed
@0xFirekeeper 0xFirekeeper deleted the firekeeper/aws-timestamps branch January 10, 2025 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants