make zk pm pminput optional

thirdweb-dev · Aug 27, 2024 · 259be1a · 259be1a
1 parent ad85a70
commit 259be1a
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 16 deletions.
diff --git a/Thirdweb.Console/Program.cs b/Thirdweb.Console/Program.cs
@@ -73,16 +73,16 @@
 
 // var smartWalletAbstract = await SmartWallet.Create(personalWallet: privateKeyWallet, chainId: 11124, gasless: true);
 
-// var hash = await smartWalletAbstract.SendTransaction(
-//     new ThirdwebTransactionInput()
+// var receipt = await smartWalletAbstract.ExecuteTransaction(
+//     new ThirdwebTransactionInput(11124)
 //     {
 //         To = await smartWalletAbstract.GetAddress(),
 //         Value = new HexBigInteger(BigInteger.Zero),
 //         Data = "0x"
 //     }
 // );
 
-// Console.WriteLine($"Transaction hash: {hash}");
+// Console.WriteLine($"Transaction hash: {receipt}");
 
 #endregion
 
@@ -98,14 +98,7 @@
 
 // var zkRawTx = await ThirdwebTransaction.Create(
 //     wallet: zkRawWallet,
-//     txInput: new ThirdwebTransactionInput(
-//         chainId: chainId,
-//         from: zkRawAddy,
-//         to: zkRawAddy,
-//         value: 0,
-//         data: "0x",
-//         zkSync: new ZkSyncOptions(paymaster: null, paymasterInput: null, gasPerPubdataByteLimit: 50000)
-//     )
+//     txInput: new ThirdwebTransactionInput(chainId: chainId, from: zkRawAddy, to: zkRawAddy, value: 0, data: "0x", zkSync: new ZkSyncOptions(gasPerPubdataByteLimit: 50000))
 // );
 
 // zkRawTx = await ThirdwebTransaction.Prepare(zkRawTx);

diff --git a/Thirdweb.Tests/Thirdweb.Transactions/Thirdweb.Transactions.Tests.cs b/Thirdweb.Tests/Thirdweb.Transactions/Thirdweb.Transactions.Tests.cs
@@ -219,8 +219,6 @@ public async Task Send_ZkSync_TransfersGaslessly()
     {
         var transaction = await this.CreateSampleTransaction();
         _ = transaction.SetChainId(300);
-        _ = transaction.SetTo("0xbA226d47Cbb2731CBAA67C916c57d68484AA269F");
-        _ = transaction.SetValue(BigInteger.Zero);
         _ = transaction.SetZkSyncOptions(
             new ZkSyncOptions(
                 paymaster: "0xbA226d47Cbb2731CBAA67C916c57d68484AA269F",
@@ -239,8 +237,6 @@ public async Task Send_ZkSync_NoGasPerPubFactoryDepsTransfersGaslessly()
     {
         var transaction = await this.CreateSampleTransaction();
         _ = transaction.SetChainId(300);
-        _ = transaction.SetTo("0xbA226d47Cbb2731CBAA67C916c57d68484AA269F");
-        _ = transaction.SetValue(BigInteger.Zero);
         _ = transaction.SetZkSyncOptions(
             new ZkSyncOptions(
                 paymaster: "0xbA226d47Cbb2731CBAA67C916c57d68484AA269F",

diff --git a/Thirdweb/Thirdweb.Transactions/ThirdwebTransactionInput.cs b/Thirdweb/Thirdweb.Transactions/ThirdwebTransactionInput.cs
@@ -161,7 +161,7 @@ public struct ZkSyncOptions
     /// <param name="paymasterInput">The paymaster input data.</param>
     /// <param name="gasPerPubdataByteLimit">The gas limit per pubdata byte.</param>
     /// <param name="factoryDeps">The factory dependencies.</param>
-    public ZkSyncOptions(string paymaster, string paymasterInput, BigInteger? gasPerPubdataByteLimit = null, List<byte[]> factoryDeps = null)
+    public ZkSyncOptions(string paymaster = null, string paymasterInput = null, BigInteger? gasPerPubdataByteLimit = null, List<byte[]> factoryDeps = null)
     {
         if (string.IsNullOrEmpty(paymaster) || string.IsNullOrEmpty(paymasterInput))
         {