Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated TbKeyFilterNode to be versioned node && removed destroy method usages because it is identical to its super method #20

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

ShvaykaD
Copy link
Contributor

@ShvaykaD ShvaykaD commented Jun 1, 2023

The PR status is set to WIP since there is no release branch for v3.5.2 created in the main repo yet. Also, this change should be applied only after the documentation for custom rule nodes will be updated: https://thingsboard.io/docs/user-guide/contribution/rule-node-development/

Hint for docs regarding the upgrade method:

/**
 * Let's imagine that after a while,
 * you will decide to upgrade the rule node configuration again,
 * for example, from version 1 to version  2.
 * In such a case, our suggestion is to replace the if statement
 * with a switch case model that will include a break statement
 * only before the default case.
 * In such way your upgrade script will be valid
 * even if you will decide to perform upgrade from version 0 to version 2.
 */

@ShvaykaD ShvaykaD added enhancement New feature or request wip Work in progress labels Jun 1, 2023
@ShvaykaD ShvaykaD added this to the 3.5.2 milestone Jun 1, 2023
@ShvaykaD ShvaykaD changed the title updated TbKeyFilterNode to be versioned node && removed destroy method because it is identical to its super method updated TbKeyFilterNode to be versioned node && removed destroy method usages because it is identical to its super method Jun 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request wip Work in progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant