fix: fix benchmark bug

things-go · Apr 16, 2024 · 7cc6165 · 7cc6165
1 parent 773974f
commit 7cc6165
Show file tree

Hide file tree

Showing 2 changed files with 42 additions and 10 deletions.
diff --git a/benchmark_json_test.go b/benchmark_json_test.go
@@ -108,6 +108,22 @@ func Benchmark_Json_NativeSugar(b *testing.B) {
 }
 
 func Benchmark_Json_SugarKeyValuePair(b *testing.B) {
+	b.ReportAllocs()
+	b.StopTimer()
+	logger := newDiscardLogger(log.FormatJson)
+	ctx := context.Background()
+	b.StartTimer()
+	for i := 0; i < b.N; i++ {
+		logger.InfowContext(ctx,
+			"success",
+			"name", "jack",
+			"age", 18,
+			dfltCtx(ctx),
+		)
+	}
+}
+
+func Benchmark_Json_SugarKeyValuePairFields(b *testing.B) {
 	b.ReportAllocs()
 	b.StopTimer()
 	logger := newDiscardLogger(log.FormatJson)
@@ -123,7 +139,7 @@ func Benchmark_Json_SugarKeyValuePair(b *testing.B) {
 	}
 }
 
-func Benchmark_Json_SugarKeyValuePair_Use_Hook(b *testing.B) {
+func Benchmark_Json_SugarKeyValuePairFields_Use_Hook(b *testing.B) {
 	b.ReportAllocs()
 	b.StopTimer()
 	logger := newDiscardLogger(log.FormatJson)
@@ -139,7 +155,7 @@ func Benchmark_Json_SugarKeyValuePair_Use_Hook(b *testing.B) {
 	}
 }
 
-func Benchmark_Json_SugarKeyValuePair_Use_WithFields(b *testing.B) {
+func Benchmark_Json_SugarKeyValuePairFields_Use_WithFields(b *testing.B) {
 	b.ReportAllocs()
 	b.StopTimer()
 	logger := newDiscardLogger(log.FormatJson)
@@ -154,7 +170,7 @@ func Benchmark_Json_SugarKeyValuePair_Use_WithFields(b *testing.B) {
 	}
 }
 
-func Benchmark_Json_SugarKeyValuePair_Use_WithFields_Hook(b *testing.B) {
+func Benchmark_Json_SugarKeyValuePairFields_Use_WithFields_Hook(b *testing.B) {
 	b.ReportAllocs()
 	b.StopTimer()
 	logger := newDiscardLogger(log.FormatJson)
@@ -169,7 +185,7 @@ func Benchmark_Json_SugarKeyValuePair_Use_WithFields_Hook(b *testing.B) {
 	}
 }
 
-func Benchmark_Json_SugarKeyValuePair_Use_WithValuer(b *testing.B) {
+func Benchmark_Json_SugarKeyValuePairFields_Use_WithValuer(b *testing.B) {
 	b.ReportAllocs()
 	b.StopTimer()
 	logger := newDiscardLogger(log.FormatJson)
@@ -184,7 +200,7 @@ func Benchmark_Json_SugarKeyValuePair_Use_WithValuer(b *testing.B) {
 	}
 }
 
-func Benchmark_Json_SugarKeyValuePair_Use_WithValuer_Hook(b *testing.B) {
+func Benchmark_Json_SugarKeyValuePairFields_Use_WithValuer_Hook(b *testing.B) {
 	b.ReportAllocs()
 	b.StopTimer()
 	logger := newDiscardLogger(log.FormatJson)

diff --git a/benchmark_text_test.go b/benchmark_text_test.go
@@ -83,6 +83,22 @@ func Benchmark_Text_NativeSugar(b *testing.B) {
 }
 
 func Benchmark_Text_SugarKeyValuePair(b *testing.B) {
+	b.ReportAllocs()
+	b.StopTimer()
+	logger := newDiscardLogger(log.FormatConsole)
+	ctx := context.Background()
+	b.StartTimer()
+	for i := 0; i < b.N; i++ {
+		logger.InfowContext(ctx,
+			"success",
+			"name", "jack",
+			"age", 18,
+			dfltCtx(ctx),
+		)
+	}
+}
+
+func Benchmark_Text_SugarKeyValuePairFields(b *testing.B) {
 	b.ReportAllocs()
 	b.StopTimer()
 	logger := newDiscardLogger(log.FormatConsole)
@@ -98,7 +114,7 @@ func Benchmark_Text_SugarKeyValuePair(b *testing.B) {
 	}
 }
 
-func Benchmark_Text_SugarKeyValuePair_Use_Hook(b *testing.B) {
+func Benchmark_Text_SugarKeyValuePairFields_Use_Hook(b *testing.B) {
 	b.ReportAllocs()
 	b.StopTimer()
 	logger := newDiscardLogger(log.FormatConsole)
@@ -114,7 +130,7 @@ func Benchmark_Text_SugarKeyValuePair_Use_Hook(b *testing.B) {
 	}
 }
 
-func Benchmark_Text_SugarKeyValuePair_Use_WithFields(b *testing.B) {
+func Benchmark_Text_SugarKeyValuePairFields_Use_WithFields(b *testing.B) {
 	b.ReportAllocs()
 	b.StopTimer()
 	logger := newDiscardLogger(log.FormatConsole)
@@ -129,7 +145,7 @@ func Benchmark_Text_SugarKeyValuePair_Use_WithFields(b *testing.B) {
 	}
 }
 
-func Benchmark_Text_SugarKeyValuePair_Use_WithFields_Hook(b *testing.B) {
+func Benchmark_Text_SugarKeyValuePairFields_Use_WithFields_Hook(b *testing.B) {
 	b.ReportAllocs()
 	b.StopTimer()
 	logger := newDiscardLogger(log.FormatConsole)
@@ -144,7 +160,7 @@ func Benchmark_Text_SugarKeyValuePair_Use_WithFields_Hook(b *testing.B) {
 	}
 }
 
-func Benchmark_Text_SugarKeyValuePair_Use_WithValuer(b *testing.B) {
+func Benchmark_Text_SugarKeyValuePairFields_Use_WithValuer(b *testing.B) {
 	b.ReportAllocs()
 	b.StopTimer()
 	logger := newDiscardLogger(log.FormatConsole)
@@ -159,7 +175,7 @@ func Benchmark_Text_SugarKeyValuePair_Use_WithValuer(b *testing.B) {
 	}
 }
 
-func Benchmark_Text_SugarKeyValuePair_Use_WithValuer_Hook(b *testing.B) {
+func Benchmark_Text_SugarKeyValuePairFields_Use_WithValuer_Hook(b *testing.B) {
 	b.ReportAllocs()
 	b.StopTimer()
 	logger := newDiscardLogger(log.FormatConsole)