fix: remove broken LTR fallbacks. Fix #18 #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thibaudcolas
approved these changes
Dec 8, 2022
There was a problem hiding this comment.
Thank you @larsenwork, completely agree with you here. Change looks spot on aside from the extra comment needing updating.
thibaudcolas
force-pushed
the
fix/remove-broken-rtl-fallbacks
branch
from
b79e6f3 to
593d609
Compare
thibaudcolas
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes LTR only fallbacks as they break in RTL context and
postcss-logicalis already a better solution for fallbacks. This simplifies the plugin and makes it more predictable (I humbly hope 😄)Closes #18
I've tried it out in a private repo and works just as expected.