Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fallbacks for rounded values break in rtl context #18

Closed
larsenwork opened this issue Nov 10, 2022 · 0 comments · Fixed by #19
Closed

Fallbacks for rounded values break in rtl context #18

larsenwork opened this issue Nov 10, 2022 · 0 comments · Fixed by #19
Labels
bug Something isn't working

Comments

@larsenwork
Copy link
Contributor

Describe the bug

The fallback values for e.g. rounded-r results in all corners being rounded when consumed in a rtl context.

which matches:

tailwindcss-vanilla-rtl/src/corePlugins.js

Line 1498 in d550539

['rounded-r', ['border-top-right-radius', 'border-start-end-radius', 'border-bottom-right-radius', 'border-end-end-radius']],

Which terms did you search for in the documentation and issue tracker?

Readme#browser-support

Environment

Latest Safari & Chrome

Expected behavior

image

Actual behavior

image

Reproducible demo

https://codepen.io/larsenwork/pen/vYrxRzQ/c403ba8fd987a00355890de11107b14d

Or maybe I'm doing something wrong? 😅
@larsenwork larsenwork added the bug Something isn't working label Nov 10, 2022
@larsenwork larsenwork mentioned this issue Nov 15, 2022
Merged
thibaudcolas pushed a commit that referenced this issue Dec 8, 2022
@larsenwork
fix: remove broken LTR fallbacks. Fix #18 (#19)
8504936 
Co-authored-by: Thibaud Colas <[email protected]>

Closes #18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: remove broken LTR fallbacks. Fix #18 larsenwork/tailwindcss-vanilla-rtl
1 participant
@larsenwork