Add js validation form #88
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Even if user is logged as root or uploader.
Have fun with the slideshow
I plead guilty, it's for IE not to fall into quirks mode. Otherwhise it's not a problem for any other browser.
The goal is not to send the form if the username is already taken. This is checked by a ajax call.
To do that I have used the jquery validation engine and the jquery i18n plugin to internationalize it. It's now easy to add validation of any kind to other form and to translate other part in js. The validation is divided in different part. All the validations that are written above the fields are enforced like only number & letter or min 6 char. But there is also an ajax call that's made to make sure the username is not already taken. If the form fail to comply with any of those validation it won't be send and a prompt will show with a message explaining the problem.
|
sorry it's a bit late because I made a pull request to myself instead of you. |
|
Issue #68 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
It's kind of a proof of concept. I have added js validation to the register form.
It's nice and everything, you get a message if your username is already taken and so on.
The goal is check that you agree with that way of doing that kind of stuff and if not to make it
compliant with your wish.
It's not perfect but for now it works kinda nicely.
Hope you will like it.
Cheers