Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for EndeavourOS #124

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add support for EndeavourOS #124

wants to merge 1 commit into from

Conversation

iguanajuice
Copy link

Title. Also working on Garuda support, but Garuda boots differently from Arch/Manjaro/EOS, so that's fun :,)

@thias
Copy link
Owner

thias commented Apr 8, 2024

Looks mostly good! A couple of things:

  • Could you please squash the commits into one for the PR to simplify the git history?
  • Looking at https://ftp.belnet.be/mirror/endeavouros/iso/ the iso regexp (EndeavourOS_[^_]+-([^-]+)\.iso) might be a bit wrong (when they have an underscore in their codename) and possible to improve. Their naming and versioning discrepancies don't help.

@iguanajuice
Copy link
Author

  • Sorry, a bit new to git. Still getting the hang of it; will do!
  • Yeah, I noticed that, too. I'm hoping they keep using a dash for their codenames in the future, but I guess that's not guaranteed unless I complain about it to the eOS devs. I'll try to find a better way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@iguanajuice @thias