Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix UI API called on a background thread #310

Closed
wants to merge 1 commit into from
Closed

Fix UI API called on a background thread #310

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 13 additions & 4 deletions Classes/IDMPhoto.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,10 +139,19 @@ - (void)loadUnderlyingImageAndNotify {

[[SDWebImageManager sharedManager] loadImageWithURL:_photoURL options:SDWebImageRetryFailed progress:^(NSInteger receivedSize, NSInteger expectedSize, NSURL * _Nullable targetURL) {
CGFloat progress = ((CGFloat)receivedSize)/((CGFloat)expectedSize);

if (self.progressUpdateBlock) {
self.progressUpdateBlock(progress);
}

if ([NSThread isMainThread]) {
if (self.progressUpdateBlock) {
self.progressUpdateBlock(progress);
}
} else {
__weak typeof(self) weakSelf = self;
dispatch_async(dispatch_get_main_queue(), ^{
if (weakSelf.progressUpdateBlock) {
weakSelf.progressUpdateBlock(progress);
}
});
}
} completed:^(UIImage * _Nullable image, NSData * _Nullable data, NSError * _Nullable error, SDImageCacheType cacheType, BOOL finished, NSURL * _Nullable imageURL) {
if (image) {
self.underlyingImage = image;
Expand Down