iPhone X Support #282
Merged
iPhone X Support #282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliveroneill
force-pushed
the
iphone_x_support
branch
2 times, most recently
from
be10bd0 to
5e69d89
Compare
Safe areas are calculated for toolbar, done button and photo frame. This accounts for orientation and fall back for pre-iOS 11 devices.
oliveroneill
force-pushed
the
iphone_x_support
branch
from
6e42785 to
c280289
Compare
result0924
added a commit
to result0924/IDMPhotoBrowser
that referenced
this pull request
Apr 26, 2018
iPhone X Support thiagoperes#282
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I realise #279 has somewhat fixed this issue, however the pull request didn't account for the bottom edge or landscape orientation. I've fixed the positioning of the done button, the toolbar and the photo so that they're positioned correctly on iPhone X and other models. This also required some minor changes to the animation when presenting the photo browser.
I've also added tests for the safe area calculations.