Fixed grammatically incorrect message while accessing pages without permission #10735
+6
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gregorbg
requested changes
Jan 29, 2025
config/locales/en.yml
Outdated
| @@ -2879,3 +2879,5 @@ en: | |||
| missing_scrambles_for_multi_error: "[%{round_id}] While you may have multiple groups in 3x3x3 Multi-Blind, at least one of the groups must contain scrambles for all attempts." | |||
| multiple_fmc_groups_warning: "[%{round_id}] There are multiple groups of FMC used. If one group of FMC was used, please use the Scrambles Matcher to uncheck the unused scrambles. Otherwise, please include a comment to WRT explaining why multiple groups of FMC were used." | |||
| wrong_number_of_scramble_sets_error: "[%{round_id}] This round has a different number of scramble sets than specified on the Manage Events tab. Please adjust the number of scramble sets in the Manage Events tab to the number of sets that were used." | |||
| application: | |||
There was a problem hiding this comment.
You already have the common and homepage keys. There is also errors.messages. Feel free to use either of those, no need to introduce a new "application" key.
gregorbg
reviewed
Feb 3, 2025
| @@ -94,7 +94,12 @@ def doorkeeper_unauthorized_render_options(error: nil) | |||
| def redirect_to_root_unless_user(action, *) | |||
| redirecting = !current_user&.send(action, *) | |||
| if redirecting | |||
| flash[:danger] = "You are not allowed to #{action.to_s.sub(/^can_/, '').chomp('?').humanize.downcase}" | |||
| flash[:danger] = case action | |||
There was a problem hiding this comment.
If the case statement only has one actual case (disregarding the else as a fallback) then why not use if?
There was a problem hiding this comment.
Oops. I have changed it to if now
gregorbg
approved these changes
Feb 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #10409