Make payment_integration a required parameter in the payment completion route
#10458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gregorbg
force-pushed
the
cleanup/payment-completion-provider-required
branch
from
2dc83a1 to
16f8e5f
Compare
dunkOnIT
approved these changes
Dec 24, 2024
gregorbg
force-pushed
the
cleanup/payment-completion-provider-required
branch
from
16f8e5f to
4c2e4fb
Compare
|
Let's wait for another day or two now that we have #10477 |
|
Should we merge+deploy now? |
|
Yay let's go! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #10234
The optional URL parameter that was in that PR (to maintain backwards compatibility) now becomes a required parameter.
All usages throughout the code have been adjusted to pass
'stripe'(or the functionally equivalent:stripe) when calling the URL helpers