Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed block finder exceptioning when no tags are present. #5

Merged
merged 2 commits into from
Oct 13, 2022

Conversation

LeadAssimilator
Copy link

This should address issue #3

@thevortex
Copy link
Owner

so i have been trying to track down a rendering glitch for ages now, is this... that?

@thevortex thevortex merged commit 4f497fa into thevortex:1.18 Oct 13, 2022
@LeadAssimilator
Copy link
Author

Could be...this is what I ran into at least when playing ATM7/ATM7S where xray would completely stop working in certain dimensions.

I also ran into an issue with simultaneous potion usage where the expiration of the first one would turn off xray prematurely. I have a fix for that as well by ref counting the draw ores enable, but it got intermixed with some code cleanup and perf improvements and doesn't feel quite right. The fix works, but some things had to be done differently than I would have expected to make single player exit/rejoin behave correctly. I'd like to understand that behavior better before sharing it but that may be a while.

@thevortex
Copy link
Owner

i appreciate it :) the fix was not even in the ballpark of what i thought was wrong LOL i spent so much time getting nowhere with this thanks again :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants