Document change review process #132
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshuagl
commented
Nov 2, 2020
mnm678
previously approved these changes
Nov 2, 2020
|
I think we're all agreed on this, but in the spirit of the proposed changes I'd appreciate a second approval. |
This was referenced Nov 24, 2020
Merged
trishankatdatadog
previously approved these changes
Nov 24, 2020
|
We should change the branch protection rules to require >= 2 reviews... |
Done. |
joshuagl
dismissed stale reviews from trishankatdatadog and mnm678
via
f271b48
joshuagl
force-pushed
the
joshuagl/change-review
branch
from
07b2b9e to
f271b48
Compare
Document the consensus builder and all active TAP Editors. Signed-off-by: Joshua Lock <[email protected]>
Define the roles of participants in the project and document the expected change review process for the specification. Signed-off-by: Joshua Lock <[email protected]>
What constitutes a business day may vary by region. Weeks are more universal. Signed-off-by: Joshua Lock <[email protected]>
Signed-off-by: Joshua Lock <[email protected]>
joshuagl
force-pushed
the
joshuagl/change-review
branch
from
f271b48 to
3799328
Compare
|
Apologies, I forced push to squash in some of the fixup commits introduced during code review and that has dismissed the existing reviews. Will need re-approval to meet the branch protection rules. Thank you in advance. |
trishankatdatadog
approved these changes
Nov 25, 2020
mnm678
approved these changes
Nov 25, 2020
|
hmm, the Travis version checks are failing. This doesn't change the specification itself, so I'm going to go ahead and merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In-line with what is discussed in #130 here's a first stab at documenting our change review process. I don't know whether 5 business days is long enough a contemplation period, or whether the term "business days" is clear enough. I'd very much welcome feedback on those aspects, as well as the rest of the proposal.
In order to ensure it's clear who will be doing the review, I've also added a
MAINTAINERS.mdlisting the consensus builder and active TAP editors. Hopefully we can link to this document from TAP 1 so that it's clear to participants in the TAP process who the TAP Editors are.Significant inspiration was taken from SPIFFE's GOVERNANCE.md