ASoC: Intel: soc-acpi-intel-ptl-match: Add cs42l43 support #5326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
naveen-manohar
requested review from
lgirdwood,
plbossart,
ranj063,
kv2019i,
dbaluta,
bardliao and
ujfalusi
as code owners
naveen-manohar
force-pushed
the
ptl-cs42l43
branch
from
ec95bae to
89ac260
Compare
plbossart
reviewed
Feb 11, 2025
| .links = ptl_cs42l43_l3, | ||
| .drv_name = "sof_sdw", | ||
| .sof_tplg_filename = "sof-ptl-cs42l43.tplg", | ||
| }, |
There was a problem hiding this comment.
any specific reason to put this here? This doesn't seem to follow any order that I understand. It mixes Bit(3) and Bit(0) definitions. Maybe best to have a clearer set of conventions on where entries get added
There was a problem hiding this comment.
Thanks for the review Pierre!!
Assumed mockup-test entries make it 1st
& then follow the usual "{platform}{codec}{link#}" convention
|
SOFCI TEST |
bardliao
previously approved these changes
Feb 17, 2025
|
SOFCI TEST |
lgirdwood
previously approved these changes
Feb 17, 2025
|
@naveen-manohar Can you fix the conflict? |
naveen-manohar
force-pushed
the
ptl-cs42l43
branch
from
89ac260 to
83b89a3
Compare
Done, Please help review. Thanks |
bardliao
reviewed
Mar 6, 2025
| .links = ptl_cs42l43_l3, | ||
| .drv_name = "sof_sdw", | ||
| .sof_tplg_filename = "sof-ptl-cs42l43-l3.tplg", | ||
| }, |
There was a problem hiding this comment.
Please put it after the mockup matches. And add .get_function_tplg_files = sof_sdw_get_tplg_files, as cs42l43 is a monolithic codec
Patch adds driver data & match table for cs42l43 multi-function codec on PTL-RVP at sdw link3. Signed-off-by: Naveen Manohar <[email protected]>
naveen-manohar
force-pushed
the
ptl-cs42l43
branch
from
83b89a3 to
ed625ce
Compare
bardliao
approved these changes
Mar 6, 2025
lgirdwood
approved these changes
Mar 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Patch adds driver data & match table for cs42l43
multi-function codec on PTL-RVP at sdw link3.