Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate the Library to Pydantic V2 and Drop Support for Python 3.8 #225

Merged
merged 22 commits into from
Sep 22, 2024
Merged

Migrate the Library to Pydantic V2 and Drop Support for Python 3.8 #225

merged 22 commits into from
Sep 22, 2024

Conversation

seriaati
Copy link
Collaborator

@seriaati seriaati commented Sep 18, 2024 •
edited
Loading

Pydantic V2 Migration.
Also drops Python 3.8 support.

@seriaati seriaati marked this pull request as ready for review September 22, 2024 00:51
thesadru
thesadru approved these changes Sep 22, 2024
View reviewed changes
Copy link
Owner

@thesadru thesadru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Migration looks good to me. I believe the gamedata might still pose problems but that's outside the scope of this PR.

@seriaati seriaati changed the title Merge dev into master Migrate the Library to Pydantic V2 Sep 22, 2024
@seriaati seriaati changed the title Migrate the Library to Pydantic V2 Migrate the Library to Pydantic V2 and Drop Support for Python 3.8 Sep 22, 2024
@seriaati seriaati merged commit a29f909 into master Sep 22, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thesadru thesadru thesadru approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@seriaati @thesadru