Make ShiyuDefense begin_time and end_time Optional #217
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hadal_begin_time
andhadal_end_time
are returned as null if the player has not challenge this season's Shiyu Defense yet.This can cause
get_shiyu_defense
to fail Pydantic validation. This PR addresses this by making bothShiyuDefense.begin_time
andShiyuDefense.end_time
Optionals.