Make transaction ID available in response #242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think this depends on the implementation of the request? It's up to the gateways to provide the correct ID |
|
In cases where the gateway returns the transaction ID, yes. But most gateways don't do that and this PR makes it easier for deveolpers of Omnipay driver to create a fully working driver. |
|
@barryvdh For example, the Paypal_Rest gateway from the omnipay/paypal doesn't receive the transaction ID from the PayPal server but also doesn't overwrite the getTransactionId() of the response object to return those from the request object. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Response:getTransactionId()returnsnullby default and most Omnipay drivers don't overwrite the method to return the ID. This PR makes the transaction ID available by default.