Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for a third address line parameter #236

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

leith
Copy link
Contributor

@leith leith commented Dec 9, 2020

Some payment gateways support an additional address line for more complex addresses. Rather than making additional accessors just for one line of addressing when everything else is supported by the CreditCard object, we can add support here directly.

@kabudu
Copy link

kabudu commented Dec 10, 2020

This is very useful!

@judgej
Copy link
Member

judgej commented Dec 10, 2020

How would you see this working with existing drivers that would never look at the address3 property? I can see if the driver is aware of it, and the application is aware that the driver is aware of it, if can be used. But for drivers that only use address1 and address2, the application is going to need to merge it into address1 and address2 anyway. Just wondering if there are any thoughts on this.

@leith
Copy link
Contributor Author

leith commented Dec 11, 2020

So in this scenario, the application wants to use address3, it's supported by the gateway, but the driver only supports address1 and address2?

I think the options here are the same as usual with any drivers, you would either fork the driver to add support for address3 and open a PR (this is my preferred approach), or you'd have to put the data into another field, which as you say is likely to be shoehorned into address1 or address2. Or I guess just accept a loss of accuracy in address going to the gateway (which may or may not be an issue depending on the gateway).

@leith
Copy link
Contributor Author

leith commented Dec 17, 2020

The CI tests are failing for a reason unrelated to this branch (they're failing for master as well): #239

Is there anything I can do to help progress this PR?

@leith
Copy link
Contributor Author

leith commented Dec 22, 2020

@barryvdh any chance of a review on this one?

@leith
Copy link
Contributor Author

leith commented Apr 16, 2021

Had another gateway with the additional address line item requirement and am having to keep using this fork in order to make it play nice. Is there anything I can do to progress this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants