-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix missing config values in webhook testing #50
base: master
Are you sure you want to change the base?
Conversation
Tests are failing for PHP 5.6 and 7.0 because phpunit no longer supports them as they've both reached end-of-life. |
Why did you add void return types? They are not supported in older PHP versions. |
I mistakenly ran the tests to confirm the change using my globally-installed version of phpunit rather than the one that ships with the project. The tests were failing because of the missing return types since phpunit no longer supports PHP versions 5.6 and 7.0. I removed the return types and re-ran the tests using the provided version of phpunit. |
Line item support
…ort-php-8 update dependencies to support php 8.1
Resolves #37