Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing config values in webhook testing #50

Open
wants to merge 14 commits into
base: master
Choose a base branch
from

Conversation

dennislindsey
Copy link

Resolves #37

@dennislindsey
Copy link
Author

Tests are failing for PHP 5.6 and 7.0 because phpunit no longer supports them as they've both reached end-of-life.

@barryvdh
Copy link
Member

barryvdh commented Oct 5, 2019

Why did you add void return types? They are not supported in older PHP versions.

@dennislindsey
Copy link
Author

I mistakenly ran the tests to confirm the change using my globally-installed version of phpunit rather than the one that ships with the project. The tests were failing because of the missing return types since phpunit no longer supports PHP versions 5.6 and 7.0. I removed the return types and re-ran the tests using the provided version of phpunit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Webhooks Testing Gives Errors
3 participants