Search for transactions #26
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently implemented on ->is criteria
|
OK noted -- can I have some test coverage before I merge please? |
|
Hi guys, why aren't you merging the pull request? We all are waiting for it so much. |
|
I haven't merged because there is no test coverage for the new methods. I have asked for this but it hasn't been provided. |
|
Thanks for your response, but it seems the developer abandoned it. Can't we try to do something with it as it is must have functionality? |
|
If you want to submit an identical PR except with test coverage then we can close this one and I can merge that one. PRs must have test coverage, them's the rules. |
|
OK, thank you, I will |
|
Sorry guys, I do not develop that project any more so I abandoned the development of that tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently implemented only
->is()criteria.Works for me for now. If I find a need to search for transaction with other conditions available I will come up with something more viable.
Well, the tests are missing.