Merge pull request #121 from filipgolonka/environment_decoupling

Removed configuring converters in Environment constructor

README.md

@@ -129,10 +129,9 @@ You can pass current `Environment` object to customize i.e. which converters sho
 
 ```php
 $environment = new Environment(array(
-    'converters' => array(
-        new HeaderConverter(),
-    ),
+    // your configuration here
 ));
+$environment->addConverter(new HeaderConverter()); // optionally - add converter manually
 
 $converter = new HtmlConverter($environment);
 

src/Environment.php

@@ -35,13 +35,6 @@ final class Environment
     public function __construct(array $config = array())
     {
         $this->config = new Configuration($config);
-
-        if (isset($config['converters'])) {
-            foreach ($config['converters'] as $converter) {
-                $this->addConverter($converter);
-            }
-        }
-
         $this->addConverter(new DefaultConverter());
     }
 

tests/EnvironmentTest.php

@@ -2,29 +2,10 @@
 
 namespace League\HTMLToMarkdown\Test;
 
-use League\HTMLToMarkdown\Converter\HeaderConverter;
 use League\HTMLToMarkdown\Environment;
 
 class EnvironmentTest extends \PHPUnit_Framework_TestCase
 {
-    public function test_creation_with_converters()
-    {
-        $environment = new Environment(array(
-            'converters' => array(
-                new HeaderConverter(),
-            ),
-        ));
-
-        $this->assertInstanceOf(
-            'League\HTMLToMarkdown\Converter\HeaderConverter',
-            $environment->getConverterByTag('h3')
-        );
-        $this->assertInstanceOf(
-            'League\HTMLToMarkdown\Converter\DefaultConverter',
-            $environment->getConverterByTag('img')
-        );
-    }
-
     public function test_creation()
     {
         $environment = Environment::createDefaultEnvironment();