Fixing memory leaks when fractal used in daemons #563
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello. I also need to run fractal in long-lived applications. My opinion is that the transformer should be immutable and the method |
|
Hey @AtCliffUnderline look at my solution of this issue. I hope it will help you to avoid memory leaks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to every transformer being filled with the current scope, there is a reference recursion.
Transformer -> Scope -> Resource -> Transformer -> Scope...This causes memory leaks in daemons and workers, I guess because GC is not able to collect these cyclomatic references; even running
gc_collect_cyclesafter each job is not helping.I think this is not breaking change, but kind of messy. Begging for comments and help with this issue