New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix sub relations when resource with modifier is included multiple times #560

Open

rogatty wants to merge 3 commits into thephpleague:master from bethinkpl:fix-multiple-subrelations-when-parent-has-modifier

rogatty commented Oct 10, 2022

When we try to include foo:modifier.bar,foo:modifier.baz, only foo and foo.bar get included, while foo.baz is ignored.

I believe this change is backward compatible, as I made sure $this->includeParams stays the same for foo:modifier(1).bar,foo:modifier(2).baz

rogatty added 3 commits

October 10, 2022 11:06


          Test that first relation modifier wins

b23eb84


          Add failing test for foo:modifier.bar,foo:modifier.baz

93f4baa


          Fix sub relations when resource with modifier is included multiple times

10e09e5

rogatty mentioned this pull request

IT-4632 | Fix sub relations when parent has modifier bethinkpl/fractal#2

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet