Merge master into 1.0.x #554
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add @matt-allan's change to changelog
…ircleci Add phpcs and circleci configurations and run phpcs check on PRs
I did this in alphabetical order :D
* Implement \JsonSerializable for Scopes * Update CHANGELOG.md noting changes from thephpleague#462
Change typehints in the phpDoc for the setters to match CursorInterface types.
…with-sub-relation Allow sub relations with modifier
update travis to allow failures on 54 and 55
…r-minimum-versions Fix tests for PHP 5.4 and 5.5
* Adding test scripts to composer.json for ease of use * Testing github actions based off thephpleague#501 * Fixing typo in matric * Fixing setup php configuration in github action * Sending coverage off to scrutinizer * Removing circle ci config * Matching travis PHP version checks * Commenting out coverage report for scrutinizer * Removing scrutinizer sending for now * Testing github action and removing travis * Adding travis config back - as it is causing issues on the PR * Pushing to separate workflows * Renaming main to run tests * Adding scrutinizer steps as final steps so coverage report can be sent * Swapping travis badge for github actions badge Co-authored-by: Steve McDougall <[email protected]>
…hephpleague#534) * clean up php code sniffer violations and update composer.json to 7.0 * remove the string typehint til 7.1 so we can pass the nullable flag * add return type hints to ScopeFactoryInterface Co-authored-by: = <=>
* Use #[\ReturnTypeWillChange] * Fix ArrayAccess interface * Fix(): Deprecated: explode(): Passing null to parameter thephpleague#2 ($string) of type string is deprecated
* Make sure CI is green * Remove .travis.yml * Minor CS * Fixed a bunch of tests * Remove scrutinizer
* Psalm fixes * PHPStan fixes * More static fixers * fixes * typo
* fix: PHP 8.1 support (thephpleague#1) * fixes Co-authored-by: oprypkhantc <[email protected]>
* Added type hints * Added all types in src * Fixed type errors in tests * fixess * Fixed testss * cs fixes
* allow for null values to be passed to Scope * nullable params * nullable for jsonapi serializer * add test coverage for resource key issue Co-authored-by: = <=>
diimpp
reviewed
Dec 18, 2023
| */ | ||
| #[\ReturnTypeWillChange] |
There was a problem hiding this comment.
Attributes are php8.0 feature and this particular attribute is php 8.1, but codebase minimal version is 7.4.
Don't tests crash on this line at 7.4?
There was a problem hiding this comment.
Attributes are comments in every version before 8.0, and in every other version they are not evaluated at runtime.
The only way this could be an issue is if someone got the attribute from the method reflection instance and tried to run $attribute->newInstance(); outside of a try/catch which is pretty unlikely since it has no reason to be instantiated in any version.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change: