Merge pull request #1748 from tinect/fix/updateSimpleS3

fix: [AsyncAwsS3] update simpleS3 for test and adjust getPresignedUrl declaration
thephpleague · Feb 4, 2024 · 7754a6a · 7754a6a
2 parents de9f800 + f9cb517
commit 7754a6a
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 4 deletions.
diff --git a/src/AsyncAwsS3/S3ClientStub.php b/src/AsyncAwsS3/S3ClientStub.php
@@ -181,7 +181,7 @@ public function getUrl(string $bucket, string $key): string
         return $this->actualClient->getUrl($bucket, $key);
     }
 
-    public function getPresignedUrl(string $bucket, string $key, ?DateTimeImmutable $expires = null): string
+    public function getPresignedUrl(string $bucket, string $key, ?DateTimeImmutable $expires = null, ?string $versionId = null): string
     {
         return $this->actualClient->getPresignedUrl($bucket, $key, $expires);
     }

diff --git a/src/AsyncAwsS3/composer.json b/src/AsyncAwsS3/composer.json
@@ -15,11 +15,10 @@
         "async-aws/s3": "^1.5 || ^2.0"
     },
     "require-dev": {
-        "async-aws/simple-s3": "^1.1 || ^2.0"
+        "async-aws/simple-s3": "^2.1"
     },
     "conflict": {
-        "symfony/http-client": "<5.2",
-        "async-aws/simple-s3": "<1.1"
+        "symfony/http-client": "<5.2"
     },
     "license": "MIT",
     "authors": [