feat!: add game version to resolveContract #519
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Reece Dunham <[email protected]>
RDIL
added
plugins
fu5ha
approved these changes
Sep 8, 2024
RDIL
commented
Sep 8, 2024
Comment on lines
-71
to
-74
| /** | ||
| * Set the category to the name of the calling function | ||
| */ | ||
| CALLER = "caller", |
There was a problem hiding this comment.
Drive-by removal of this because it causes a deoptimization to occur for every call of log, meaning any function that calls log will be much slower as a result. For things like recursive or repeated calls, this causes exponential time loss.
fyi @LennardF1989 - future migration will be to add more manual category names. Eventually, we should probably make this required.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scope
Sorry Fusha in advance.
Migrates the contract resolution system to be versioned by game.
Includes backwards compatibility shims for plugins.
Test Plan
I have not yet tested.
Checklist