Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Stingray & Opulent debriefings to the campaign menu #508

Merged
merged 3 commits into from
Aug 15, 2024

Conversation

thecatontheceiling
Copy link
Contributor

@thecatontheceiling thecatontheceiling commented Aug 14, 2024

Scope

Added the cutscenes to the campaign list so they show up in-game without having to play through the entire mission everytime you need to access it

Test Plan

I have not verified if these changes work or not. I made this PR using my shitty Samsung phone which probably cannot emulate WoA.

The only thing missing afaik is the tile images:

images/cinematics/tiles_s2/cinematic09.jpg
images/cinematics/tiles_s2/cinematic10.jpg

They can be made and added to ImagePack although I'm not sure if that will work or not immediately.

Dribbleondo made images that could be used

Relevant discord conversation

Checklist

  • I have run Prettier to reformat any changed files
  • I have verified my changes work

@infradragon

This comment was marked as resolved.

@suanjiansalt
Copy link
Contributor

my question is, why does it have to be a feature of Peacock

@thecatontheceiling
Copy link
Contributor Author

thecatontheceiling commented Aug 14, 2024

For the sake of consistency I think these cutscenes should be easily accessable in the Season 2 campaign among the missions they're for.

They only get played after the missions are completed and they can't be accessed from the menu like every other debriefing which makes it a weird inconsistency.

I don't really see why not

@thecatontheceiling thecatontheceiling marked this pull request as ready for review August 14, 2024 12:13
@dribbleondo
Copy link

For the sake of consistency I think these cutscenes should be easily accessable in the Season 2 campaign among the missions they're for, for easy access.

They only get played after the missions are completed and they can't be accessed from the menu like every other debriefing which makes it a weird inconsistency.

I don't really see why not

Seconded. It's a weird choice to keep these only viewable after you play a level.

@Watchman3001
Copy link
Contributor

Agree. Definitely wouldn't hurt to have those debriefing videos available without having to play through the mission again, or go on YouTube

@suanjiansalt
Copy link
Contributor

In any case it's not a must option in Peacock. Being an attachment plugin of a mod could be more suitable.

@RDIL
Copy link
Member

RDIL commented Aug 14, 2024

Feels like a reasonable thing to have in core. It’s not new content, just a button to access existing content.

@thecatontheceiling
Copy link
Contributor Author

Feels like a reasonable thing to have in core. It’s not new content, just a button to access existing content.

This concept of adding buttons to access existing content isn't very new to peacock in the first place
https://thepeacockproject.org/wiki/features/elusive-targets

@RDIL
Copy link
Member

RDIL commented Aug 15, 2024

Willing to merge this, please PR in the images to the image pack. No more then 200kb per image, must be jpg.

@RDIL RDIL merged commit e668afc into thepeacockproject:master Aug 15, 2024
5 checks passed
@thecatontheceiling thecatontheceiling deleted the haven-cutscene branch August 16, 2024 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants