Enable strict types mode

components/candle/challengeHelpers.ts

@@ -18,7 +18,6 @@
 
 import {
     ChallengeProgressionData,
-    CompiledChallengeRewardData,
     CompiledChallengeRuntimeData,
     InclusionData,
     MissionManifest,
@@ -28,19 +27,6 @@ import { SavedChallengeGroup } from "../types/challenges"
 import { controller } from "../controller"
 import { gameDifficulty, isSniperLocation } from "../utils"
 
-// TODO: unused?
-export function compileScoringChallenge(
-    challenge: RegistryChallenge,
-): CompiledChallengeRewardData {
-    return {
-        ChallengeId: challenge.Id,
-        ChallengeName: challenge.Name,
-        ChallengeDescription: challenge.Description,
-        ChallengeImageUrl: challenge.ImageName,
-        XPGain: challenge.Rewards?.MasteryXP || 0,
-    }
-}
-
 export function compileRuntimeChallenge(
     challenge: RegistryChallenge,
     progression: ChallengeProgressionData,
@@ -106,8 +92,8 @@ export type ChallengeFilterOptions =
  * @returns A boolean as the result.
  */
 export function inclusionDataCheck(
-    incData: InclusionData,
-    contract: MissionManifest,
+    incData: InclusionData | undefined,
+    contract: MissionManifest | undefined,
 ): boolean {
     if (!incData) return true
     if (!contract) return false
@@ -174,24 +160,24 @@ function isChallengeInContract(
                 : {
                       ...challenge.InclusionData,
                       ContractTypes:
-                          challenge.InclusionData.ContractTypes.filter(
+                          challenge.InclusionData?.ContractTypes?.filter(
                               (type) => type !== "tutorial",
-                          ),
+                          ) || [],
                   },
             contract,
         )
     }
 
     // Is this for the current contract or group contract?
     const isForContract = (challenge.InclusionData?.ContractIds || []).includes(
-        contract.Metadata.Id,
+        contract?.Metadata.Id || "",
     )
 
     // Is this for the current contract type?
     // As of v6.1.0, this is only used for ET challenges.
     const isForContractType = (
         challenge.InclusionData?.ContractTypes || []
-    ).includes(controller.resolveContract(contractId).Metadata.Type)
+    ).includes(controller.resolveContract(contractId)!.Metadata.Type)
 
     // Is this a location-wide challenge?
     // "location" is more widely used, but "parentlocation" is used in Ambrose and Berlin, as well as some "Discover XX" challenges.
@@ -287,7 +273,7 @@ export function filterChallenge(
  */
 export function mergeSavedChallengeGroups(
     g1: SavedChallengeGroup,
-    g2: SavedChallengeGroup,
+    g2?: SavedChallengeGroup,
 ): SavedChallengeGroup {
     return {
         ...g1,