Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement GetMasteryCompletionForLocation (legacy version) #509

Closed
RDIL opened this issue Aug 14, 2024 · 1 comment · Fixed by #502
Closed

Implement GetMasteryCompletionForLocation (legacy version) #509

RDIL opened this issue Aug 14, 2024 · 1 comment · Fixed by #502
Assignees
@RDIL
Labels
h2016 Related to H2016 engine or Frankenstein. progression Related to the gaining of mastery and other in-game progress.
Milestone
v8

Comments

@RDIL
Copy link
Member

RDIL commented Aug 14, 2024 •
edited
Loading

Describe the bug
(Post-req for #502)

H2016 has it's own route which is different from the existing GetMasteryCompletionForLocation. It will need to be implemented.

I believe this may be what causes pro mode to require going offline and back online once unlocked.
@RDIL RDIL added progression Related to the gaining of mastery and other in-game progress. h2016 Related to H2016 engine or Frankenstein. labels Aug 14, 2024
@RDIL RDIL added this to the v8 milestone Aug 14, 2024
@RDIL RDIL self-assigned this Aug 14, 2024
@RDIL RDIL mentioned this issue Aug 14, 2024
Merged
5 tasks
@AnthonyFuller
Copy link
Contributor

Not the issue. We have to send the client an event.

AnthonyFuller added a commit that referenced this issue Aug 15, 2024
@AnthonyFuller
Implement GetMasteryCompletionDataForLocation
61eb4ef 
Closes #509
@AnthonyFuller AnthonyFuller linked a pull request Aug 15, 2024 that will close this issue
feat: Pro1 challenges, h6 & general mastery improvements #502
Merged
5 tasks
AnthonyFuller added a commit that referenced this issue Aug 18, 2024
@AnthonyFuller
feat: implement GetMasteryCompletionDataForLocation
11595ad 
Closes #509
@RDIL RDIL closed this as completed in 5711f44 Aug 19, 2024
@RDIL RDIL closed this as completed in #502 Aug 19, 2024
@github-project-automation github-project-automation bot moved this from 🆕 New to ✅ Done in Challenges & Progression Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@RDIL RDIL

Labels
h2016 Related to H2016 engine or Frankenstein. progression Related to the gaining of mastery and other in-game progress.
Projects
Challenges & Progression
Status: ✅ Done
Milestone
v8
Development

Successfully merging a pull request may close this issue.

feat: Pro1 challenges, h6 & general mastery improvements thepeacockproject/Peacock
2 participants
@AnthonyFuller @RDIL