Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Pro1 challenges, h6 & general mastery improvements #502

Merged
merged 20 commits into from
Aug 19, 2024
Merged

feat: Pro1 challenges, h6 & general mastery improvements #502

merged 20 commits into from
Aug 19, 2024

Conversation

RDIL
Copy link
Member

@RDIL RDIL commented Aug 8, 2024 •
edited
Loading

Scope

  • Add h6's professional mode challenges
  • Some refactoring to the services that power all this to improve clarity.

Remaining to-do(?)

Test Plan

I have in fact tested the code works on 2016. maybe some extra regression testing is needed for newer game versions, but hey, that's what betas are for

Checklist

  • I have run Prettier to reformat any changed files
  • I have verified my changes work

@RDIL RDIL changed the title feat: Pro1 challenges feat: Pro1 challenges & h6 improvements Aug 10, 2024
RDIL
RDIL commented Aug 10, 2024
View reviewed changes
components/2016/legacyProfileRouter.ts Show resolved Hide resolved
components/menuData.ts Show resolved Hide resolved
components/scoreHandler.ts Show resolved Hide resolved
components/scoreHandler.ts Show resolved Hide resolved
components/scoreHandler.ts Show resolved Hide resolved
@RDIL RDIL requested a review from moonysolari August 10, 2024 02:02
This was linked to issues Aug 10, 2024
H2016 and Challenges #20
Open
Hitman 1 Professional Mode Support #296
Closed
Normal and pro1 challenges for H2016 #308
Closed
RDIL
RDIL commented Aug 10, 2024
View reviewed changes
components/menuData.ts Outdated Show resolved Hide resolved
@RDIL RDIL marked this pull request as ready for review August 14, 2024 22:02
@RDIL RDIL added this to the v8 milestone Aug 14, 2024
@RDIL RDIL mentioned this pull request Aug 14, 2024
Closed
@RDIL RDIL removed a link to an issue Aug 14, 2024
H2016 and Challenges #20
Open
5 tasks
@RDIL RDIL mentioned this pull request Aug 14, 2024
Open
5 tasks
AnthonyFuller
AnthonyFuller requested changes Aug 14, 2024
View reviewed changes
components/scoreHandler.ts Outdated Show resolved Hide resolved
components/scoreHandler.ts Outdated Show resolved Hide resolved
@AnthonyFuller AnthonyFuller linked an issue Aug 15, 2024 that may be closed by this pull request
Implement GetMasteryCompletionForLocation (legacy version) #509
Closed
AnthonyFuller
AnthonyFuller reviewed Aug 18, 2024
View reviewed changes
components/scoreHandler.ts
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This also sends the Progression_LevelGain event to the client to pop mastery achievements on mission end.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ref #489

@RDIL RDIL linked an issue Aug 18, 2024 that may be closed by this pull request
Achievements pertaining to Lvl 20 Mastery not unlocking. #489
Closed
AnthonyFuller
AnthonyFuller approved these changes Aug 18, 2024
View reviewed changes
Copy link
Contributor

@AnthonyFuller AnthonyFuller left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, not experienced the progress bar issue in at least a double digit number of runs now.

EDIT: General Mastery Improvements 🫡

@AnthonyFuller AnthonyFuller changed the title feat: Pro1 challenges & h6 improvements feat: Pro1 challenges, h6 improvements & general mastery improvements Aug 18, 2024
@AnthonyFuller AnthonyFuller changed the title feat: Pro1 challenges, h6 improvements & general mastery improvements feat: Pro1 challenges, h6 & general mastery improvements Aug 18, 2024
@RDIL RDIL merged commit 8d98779 into master Aug 19, 2024
5 checks passed
@RDIL RDIL deleted the rdil/pro1-challenges branch August 19, 2024 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AnthonyFuller AnthonyFuller AnthonyFuller approved these changes

@moonysolari moonysolari Awaiting requested review from moonysolari

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v8
2 participants
@RDIL @AnthonyFuller