Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve data type parsing and formatting #317

Merged
merged 1 commit into from
Sep 23, 2023
Merged

Improve data type parsing and formatting #317

merged 1 commit into from
Sep 23, 2023

Commits on Sep 23, 2023

  1. Improve data type parsing and formatting

    Add a C module to delegate the parsing of data types by `col_type_is()`
    to the Postgres core `parseTypeString()` function, which is the
    canonical type parser. This ensure that no matter the aliasing or
    typemod specified for a data type, we end up with exactly the same
    spelling as the core uses, ensuring more accurate comparisons. This was
    necessitated by the change in 1e1d745 that added support for type
    aliases but broke complicated typmods such as ` second(0)` in `interval
    second(0)`. Resolves #315.
    
    Document the two new functions, `parse_type()` and
    `format_type_string()` and remove the documentation for `pg_typeof()`,
    which hasn't shipped with pgTAP in several years, since it has been in
    the Postgres core since 8.3.
    
    Also, fix the name of the v1.3.9 upgrade file.
    theory committed Sep 23, 2023
    Configuration menu
    Copy the full SHA
    4ec32e7 View commit details
    Browse the repository at this point in the history