fix: more publish fixes (#9)

theogravity · Apr 8, 2024 · 713aac6 · 713aac6
1 parent 81b32c8
commit 713aac6
Show file tree

Hide file tree

Showing 10 changed files with 55 additions and 20 deletions.
diff --git a/.changeset/famous-kiwis-attack.md b/.changeset/famous-kiwis-attack.md
@@ -0,0 +1,5 @@
+---
+"electron-log-transport-datadog": patch
+---
+
+fix: more publish fixes
diff --git a/.github/workflows/lint.yml b/.github/workflows/lint.yml
@@ -2,9 +2,6 @@ name: Lint
 
 on:
   pull_request:
-  push:
-    branches:
-      - main
 
 jobs:
   lint:

diff --git a/.github/workflows/release-snapshot.yml b/.github/workflows/release-snapshot.yml
@@ -3,6 +3,9 @@ name: Snapshot Release
 on:
   workflow_dispatch:
 
+env:
+  PNPM_CACHE_FOLDER: .pnpm-store
+
 jobs:
   snapshot:
     name: Snapshot Release
@@ -14,10 +17,25 @@ jobs:
       - name: Use pnpm
         uses: pnpm/action-setup@v3
         with:
-          version: 8
+          version: 8.x
+
+      - name: setup pnpm config
+        run: pnpm config set store-dir $PNPM_CACHE_FOLDER
 
       - name: Install Dependencies
-        run: pnpm install --frozen-lockfile --prefer-offline
+        run: pnpm install --frozen-lockfile
+
+      - name: Build workspace packages
+        run: pnpm build
+
+      - name: Run package checking
+        run: pnpm run lint:packages
+
+      - name: Run type checking
+        run: pnpm run typecheck
+
+      - name: Run linting
+        run: pnpm run lint
 
       - name: Create Snapshot Release
         run: |

diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml
@@ -5,6 +5,9 @@ on:
     branches:
       - main
 
+env:
+  PNPM_CACHE_FOLDER: .pnpm-store
+
 concurrency: ${{ github.workflow }}-${{ github.ref }}
 
 jobs:
@@ -18,10 +21,25 @@ jobs:
       - name: Use pnpm
         uses: pnpm/action-setup@v3
         with:
-          version: 8
+          version: 8.x
+
+      - name: setup pnpm config
+        run: pnpm config set store-dir $PNPM_CACHE_FOLDER
 
       - name: Install Dependencies
-        run: pnpm install --frozen-lockfile --prefer-offline
+        run: pnpm install --frozen-lockfile
+
+      - name: Build workspace packages
+        run: pnpm build
+
+      - name: Run package checking
+        run: pnpm run lint:packages
+
+      - name: Run type checking
+        run: pnpm run typecheck
+
+      - name: Run linting
+        run: pnpm run lint
 
       - name: Create Release Pull Request
         uses: changesets/action@v1
@@ -32,4 +50,4 @@ jobs:
           title: 'chore: release package(s)'
         env:
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
-          NPM_TOKEN: ${{ secrets.NPM_TOKEN }}
+          NPM_TOKEN: ${{ secrets.NPM_TOKEN }}
diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
@@ -2,9 +2,6 @@ name: Test
 
 on:
   pull_request:
-  push:
-    branches:
-      - main
 
 jobs:
   test:
@@ -37,4 +34,4 @@ jobs:
 
       - name: Run Package(s) Tests
         run: |
-          pnpm run test
+          pnpm run test
diff --git a/.gitignore b/.gitignore
@@ -37,3 +37,4 @@ yarn-error.log*
 .DS_Store
 *.pem
 .idea/
+.pnpm-store/
diff --git a/biome.json b/biome.json
@@ -13,12 +13,14 @@
       "*.config.*",
       "*.json",
       "tsconfig.json",
-      ".turbo"
+      ".turbo",
+      "dist/*",
+      ".pnpm-store/*"
     ]
   },
   "linter": {
     "enabled": true,
-    "ignore": ["vendor/*"],
+    "ignore": ["vendor/*", "dist/*", ".pnpm-store/*"],
     "rules": {
       "performance": {
         "noDelete": "off"

diff --git a/packages/datadog-transport-common/package.json b/packages/datadog-transport-common/package.json
@@ -22,8 +22,7 @@
     "format": "biome format src --write && biome format test --write",
     "lint": "biome lint src && biome lint test",
     "lint:check": "biome check --apply-unsafe src && check --apply-unsafe test",
-    "typecheck": "tsc --noEmit",
-    "prepublishOnly": "pnpm run build"
+    "typecheck": "tsc --noEmit"
   },
   "publishConfig": {
     "access": "public"

diff --git a/packages/electron-log-transport-datadog/package.json b/packages/electron-log-transport-datadog/package.json
@@ -22,8 +22,7 @@
     "format": "biome format src --write && biome format test --write",
     "lint": "biome lint src && biome lint test",
     "lint:check": "biome check --apply-unsafe src && check --apply-unsafe test",
-    "typecheck": "tsc --noEmit",
-    "prepublishOnly": "pnpm run build"
+    "typecheck": "tsc --noEmit"
   },
   "publishConfig": {
     "access": "public"

diff --git a/packages/pino-datadog-transport/package.json b/packages/pino-datadog-transport/package.json
@@ -21,8 +21,7 @@
     "format": "biome format src --write && biome format test --write",
     "lint": "biome lint src && biome lint test",
     "lint:check": "biome check --apply-unsafe src && check --apply-unsafe test",
-    "typecheck": "tsc --noEmit",
-    "prepublishOnly": "pnpm run build"
+    "typecheck": "tsc --noEmit"
   },
   "repository": {
     "type": "git",
-Original file line number
+Diff line change
@@ Expand Up / @@ -2,9 +2,6 @@ name: Lint @@
     on:
       pull_request:
-      push:
-        branches:
-          - main
     jobs:
       lint:
@@ Expand Down @@