Make kinds true singletons #13
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…del. The tab is now drawable, so that the selection model can be used.
Change the name of the JS file to similitudeClient.js.
…e these stateless.
Eliminate the VALUE_LOGIC enumeration.
|
Superceeded. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I removed all state from the ComponentKind classes with the exception of CompoundComponentKind. This was the intended design from the beginning and I'm not sure how it got screwed up.
Of course I probably broke a whole lot of stuff because there are no unit tests for the model; which is a serious problem in itself. One thing I know I broke is reordering of ports on CompoundComponentKindsl this code was in the drawing routine of Component, of all places! I just deleted it. I'm going to make an issue out of that and a board for issues.