Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardize config classes #217

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

BreyndotEchse
Copy link

  • Downgrade symfony/cache to 6.4 (LTS): 7.x requires PHP 8.2+
  • Move openai-php/client to require-dev & suggest: OpenAI is not required for Ollama or Anthropic chats. Treat it like other soft deps
  • Standardize config classes: Config classes were rather different. One used public properties only, another accepted constructor params as well. One used constants, another enums. One set its defaults in the config class, another used a constant in the respective chat class and so on... Now everything concerning configuration is found in the config classes.

@BreyndotEchse
Copy link
Author

Error is false-positive. Runs without any issues with latest pestphp/pest*, phpstan/phpstan, rector/re
ctor versions

@fballiano
Copy link
Contributor

Since I only use ollama I'd also prefer to have openai-sdk as optional, while php8.2+ is file for me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants