Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test also on the soon-to-be-release python 3.13 #350

Closed
wants to merge 2 commits into from

Conversation

tovrstra
Copy link
Member

@tovrstra tovrstra commented Jun 23, 2024

Not sure if this is going to work, but it would be good to know. Fingers crossed.... (Mentioned in #204)

Summary by Sourcery

This pull request updates the CI configuration to include testing on Python 3.13, ensuring compatibility with the upcoming Python release.

  • CI:
    • Added Python 3.13 to the testing matrix in the GitHub Actions workflow.

Copy link
Contributor

sourcery-ai bot commented Jun 23, 2024

Reviewer's Guide by Sourcery

This pull request updates the GitHub Actions workflow configuration to include Python 3.13 in the testing matrix. This change ensures that the codebase is tested against the upcoming Python 3.13 release, in addition to the existing versions (3.9 and 3.12).

File-Level Changes

Files Changes
.github/workflows/pytest.yaml Updated the GitHub Actions workflow to include testing on Python 3.13.

Tips
  • Trigger a new Sourcery review by commenting @sourcery-ai review on the pull request.
  • You can change your review settings at any time by accessing your dashboard:
    • Enable or disable the Sourcery-generated pull request summary or reviewer's guide;
    • Change the review language;
  • You can always contact us if you have any questions or feedback.

Copy link

deepsource-io bot commented Jun 23, 2024

Here's the code health analysis summary for commits b5bccd9..90faea3. View details on DeepSource ↗.

Analysis Summary

AnalyzerStatusSummaryLink
DeepSource Shell LogoShell✅ SuccessView Check ↗
DeepSource Python LogoPython✅ SuccessView Check ↗

💡 If you’re a repository administrator, you can configure the quality gates from the settings.

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @tovrstra - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.

@tovrstra
Copy link
Member Author

No go, due to lacking compiled packages for NumPy and SciPy. We can try again later.

@tovrstra tovrstra closed this Jun 23, 2024
@tovrstra tovrstra deleted the test-python-313 branch June 23, 2024 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant