Test notebook #147
Merged
Test notebook #147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed the calls to the MaxMin selector to comply with the new api.
Fix call to the selector to comply with the new api.
Fix call to the selector
The example using mocked data was also fixed and the code cleaned
Small fixes were done so that the examples using `DirectedSphereExclusion` could work. The lines with `selector.select(coords_cluster, size=12,labels=class_labels_cluster)` got broken with the last updates to the `DirectedSphereExclusion`. Now the example only work if `labels=class_labels_cluster` is removed. It is necessary to find why.
Codecov Report
@@ Coverage Diff @@
## main #147 +/- ##
=======================================
Coverage 40.54% 40.54%
=======================================
Files 8 8
Lines 555 555
=======================================
Hits 225 225
Misses 330 330 |
|
Thanks for your efforts in building the notebook. @marco-2023
Sorry to put such a long list of questions, but I just want to also make it clear for some potential questions from the audience. Thanks. |
FarnazH
approved these changes
Jul 28, 2023
|
@marco-2023 I think this is good to go, probably, but it's good to respond to Fanwang's questions for documentation/bug-catching purposes. |
6 tasks
|
Thank you for the nice work on this issue. I will merge this PR, but will leave a few more questions in #152. |
Merged
JackyZzZz
pushed a commit
to JackyZzZz/Selector
that referenced
this pull request
Jun 14, 2024
Update usages of the notebook because of the API changes
FanwangM
added a commit
that referenced
this pull request
Jul 2, 2024
Update usages of the notebook because of the API changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made necessary changes so that the notebook runs. Added some observations regarding some methods' results to the notebook.