-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test notebook #147
Test notebook #147
Conversation
Fixed the calls to the MaxMin selector to comply with the new api.
Fix call to the selector to comply with the new api.
Fix call to the selector
The example using mocked data was also fixed and the code cleaned
Small fixes were done so that the examples using `DirectedSphereExclusion` could work. The lines with `selector.select(coords_cluster, size=12,labels=class_labels_cluster)` got broken with the last updates to the `DirectedSphereExclusion`. Now the example only work if `labels=class_labels_cluster` is removed. It is necessary to find why.
Codecov Report
@@ Coverage Diff @@
## main #147 +/- ##
=======================================
Coverage 40.54% 40.54%
=======================================
Files 8 8
Lines 555 555
=======================================
Hits 225 225
Misses 330 330 |
Thanks for your efforts in building the notebook. @marco-2023
Sorry to put such a long list of questions, but I just want to also make it clear for some potential questions from the audience. Thanks. |
@marco-2023 I think this is good to go, probably, but it's good to respond to Fanwang's questions for documentation/bug-catching purposes. |
Thank you for the nice work on this issue. I will merge this PR, but will leave a few more questions in #152. |
Update usages of the notebook because of the API changes
Update usages of the notebook because of the API changes
Made necessary changes so that the notebook runs. Added some observations regarding some methods' results to the notebook.