Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GitHub Actions Testing #23

Merged
merged 5 commits into from
Feb 20, 2024
Merged

GitHub Actions Testing #23

merged 5 commits into from
Feb 20, 2024

Conversation

maximilianvz
Copy link
Collaborator

As requested in Issue #14, I have uploaded a workflow to run pytest each time something is pushed to master or a PR is created.

@maximilianvz
Update pytest.yaml
ae4d8a2
@maximilianvz
Change Python versions and iodata installation
df8687b 
`distutils` was removed from Python 3.12. It appears as though there is some problem installing IOData with `pip install qc-iodata` on Windows OS.
@maximilianvz
Copy link
Collaborator Author

maximilianvz commented Feb 6, 2024 •
edited
Loading

Right now, all the automatic tests on OS ubuntu-lastest are failing, but this should sort itself out when we switch to pyproject.toml rather than setup.py as I suggest in PR #22. I think this will also solve the problem with tests on OS windows-latest.

msricher
msricher approved these changes Feb 14, 2024
View reviewed changes
Copy link
Collaborator

@msricher msricher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes this seems perfectly fine to me. It should work when things are ported to pyproject.toml.

@gabrielasd gabrielasd merged commit 1ddf7b6 into theochem:master Feb 20, 2024
0 of 9 checks passed
msricher pushed a commit that referenced this pull request May 13, 2024
@gabrielasd
Merge pull request #23 from maximilianvz/github_actions_testing
35a8a72 
GitHub Actions Testing
msricher pushed a commit that referenced this pull request May 13, 2024
@gabrielasd
Merge pull request #23 from maximilianvz/github_actions_testing
2736029 
GitHub Actions Testing
marco-2023 pushed a commit that referenced this pull request May 13, 2024
@gabrielasd
Merge pull request #23 from maximilianvz/github_actions_testing
3f7a763 
GitHub Actions Testing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msricher msricher msricher approved these changes

@FarnazH FarnazH Awaiting requested review from FarnazH

@gabrielasd gabrielasd Awaiting requested review from gabrielasd

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@maximilianvz @msricher @gabrielasd