Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing disabled style and doc code for textarea #307

Merged
merged 2 commits into from
Aug 1, 2024

Conversation

ogzcode
Copy link
Contributor

@ogzcode ogzcode commented Jul 24, 2024

#306

Completed codes for the above issue.

1.Disabled style added
2.Missing doc code added

Please check and confirm the PR. I will be waiting for feedback

@Sqrcz @cogor @zoltanszogyenyi @robert1508

Summary by CodeRabbit

  • New Features

    • Introduced length constraints on the fwb-textarea component, requiring a minimum of 10 and a maximum of 20 characters for user input.
    • Enhanced visual indicators for disabled state with new cursor and opacity styles, improving user experience.
  • Documentation

    • Updated the documentation for fwb-textarea to reflect the new minimum and maximum length capabilities.

Copy link
Contributor

coderabbitai bot commented Jul 24, 2024

Walkthrough

The recent updates enhance the fwb-textarea component by adding input length validation and improving the visual indication of its disabled state. Specifically, new attributes for minimum and maximum character lengths have been introduced, alongside CSS classes to visually denote the disabled state, thereby enriching both user experience and documentation clarity.

Changes

File Change Summary
docs/components/textarea.md Added attributes minlength="10" and maxlength="20" to fwb-textarea documentation.
src/components/FwbTextarea/composables/useTextareaClasses.ts Added disabled:cursor-not-allowed and disabled:opacity-50 classes for improved disabled state visibility.

Possibly related issues

Poem

🐰 In a world where text can flow,
Lengthy tales we now bestow.
With disabled states so clear and bright,
Our textarea shines with new delight!
Bound by limits, yet free to express,
Hop along, dear user, and surely impress! 🌟


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

netlify bot commented Jul 24, 2024

Deploy Preview for sensational-seahorse-8635f8 ready!

Name Link
🔨 Latest commit c7189b5
🔍 Latest deploy log https://app.netlify.com/sites/sensational-seahorse-8635f8/deploys/66a0fb89bb251f000812de0e
😎 Deploy Preview https://deploy-preview-307--sensational-seahorse-8635f8.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between a0f04ed and c7189b5.

Files selected for processing (2)
  • docs/components/textarea.md (1 hunks)
  • src/components/FwbTextarea/composables/useTextareaClasses.ts (1 hunks)
Additional comments not posted (2)
src/components/FwbTextarea/composables/useTextareaClasses.ts (1)

5-5: LGTM! The added CSS classes improve accessibility and usability.

The addition of disabled:cursor-not-allowed and disabled:opacity-50 enhances the visual indication of the disabled state, providing a better user experience.

docs/components/textarea.md (1)

105-111: LGTM! The added attributes enhance input validation.

The addition of minlength="10" and maxlength="20" to the fwb-textarea component improves user input validation and provides clearer guidance in the documentation.

Copy link
Collaborator

@Sqrcz Sqrcz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes the issue... thank you!

@Sqrcz Sqrcz merged commit a39cad3 into themesberg:main Aug 1, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants