-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Missing disabled style and doc code for textarea #307
Conversation
WalkthroughThe recent updates enhance the Changes
Possibly related issues
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
✅ Deploy Preview for sensational-seahorse-8635f8 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (2)
- docs/components/textarea.md (1 hunks)
- src/components/FwbTextarea/composables/useTextareaClasses.ts (1 hunks)
Additional comments not posted (2)
src/components/FwbTextarea/composables/useTextareaClasses.ts (1)
5-5
: LGTM! The added CSS classes improve accessibility and usability.The addition of
disabled:cursor-not-allowed
anddisabled:opacity-50
enhances the visual indication of the disabled state, providing a better user experience.docs/components/textarea.md (1)
105-111
: LGTM! The added attributes enhance input validation.The addition of
minlength="10"
andmaxlength="20"
to thefwb-textarea
component improves user input validation and provides clearer guidance in the documentation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixes the issue... thank you!
#306
Completed codes for the above issue.
1.Disabled style added
2.Missing doc code added
Please check and confirm the PR. I will be waiting for feedback
@Sqrcz @cogor @zoltanszogyenyi @robert1508
Summary by CodeRabbit
New Features
fwb-textarea
component, requiring a minimum of 10 and a maximum of 20 characters for user input.Documentation
fwb-textarea
to reflect the new minimum and maximum length capabilities.