-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Textarea props #305
Textarea props #305
Conversation
WalkthroughThe recent updates enhance the user interface for input components in a Vue.js application, introducing a new Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
✅ Deploy Preview for sensational-seahorse-8635f8 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (5)
- docs/components/textarea.md (1 hunks)
- docs/components/textarea/examples/FwbTextareaExampleDisabled.vue (1 hunks)
- src/components/FwbFileInput/FwbFileInput.vue (1 hunks)
- src/components/FwbTextarea/FwbTextarea.vue (3 hunks)
- src/components/FwbTextarea/composables/useTextareaClasses.ts (1 hunks)
Files skipped from review due to trivial changes (1)
- docs/components/textarea/examples/FwbTextareaExampleDisabled.vue
Additional comments not posted (6)
src/components/FwbTextarea/composables/useTextareaClasses.ts (1)
5-5
: LGTM!The addition of
disabled:cursor-not-allowed
anddisabled:opacity-50
enhances the visual feedback for disabled textarea elements, improving accessibility and user experience.src/components/FwbTextarea/FwbTextarea.vue (2)
11-12
: LGTM!The
maxLength
andminLength
props are correctly integrated and bound to the textarea element, improving input validation and user experience.
34-35
: LGTM!The
maxLength
andminLength
props are correctly added to theTextareaProps
interface with appropriate default values, enhancing the component's flexibility and usability.Also applies to: 48-49
src/components/FwbFileInput/FwbFileInput.vue (2)
18-18
: LGTM!The change from
"flex items-center justify-center"
to"flex flex-col items-start justify-center"
improves the layout by shifting from a horizontal to a vertical alignment of child elements.
23-23
: LGTM!The addition of a
<span>
element to display the label if thelabel
property is not an empty string enhances the component's usability by providing context to the user.docs/components/textarea.md (1)
105-111
: LGTM! Verify the correct implementation ofmax-length
andmin-length
props.The addition of
max-length
andmin-length
props enhances the functionality by allowing developers to set character limits. Ensure that these props are correctly implemented in thefwb-textarea
component.
#268
Added feat for above issue ☝️
Please check and approve this PR. I will be waiting for your feedback
@Sqrcz @cogor @zoltanszogyenyi @robert1508
Summary by CodeRabbit
New Features
<fwb-textarea>
component for improved message input with validation for character limits.Enhancements
User Interface Changes