Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix element role in NavLi #1484

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix element role in NavLi #1484

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e4e5c23
fix element role in NavLi
LahTeuto Nov 12, 2024
7d63ead
add 'presentation' aria role if NavLi element is not a link
LahTeuto Nov 12, 2024
ed24cdc
Code formatting for NavLi component
LahTeuto Nov 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 17 additions & 1 deletion src/lib/navbar/NavLi.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,23 @@
</script>

<li>
<svelte:element this={href ? 'a' : 'div'} role={href ? undefined : 'link'} {href} {...$$restProps} on:blur on:change on:click on:focus on:keydown on:keypress on:keyup on:mouseenter on:mouseleave on:mouseover class={liClass}>
<svelte:element
this={href ? 'a' : 'div'}
role={href ? 'link' : 'presentation'}
{href}
{...$$restProps}
on:blur
on:change
on:click
on:focus
on:keydown
on:keypress
on:keyup
on:mouseenter
on:mouseleave
on:mouseover
class={liClass}
>
<slot />
</svelte:element>
</li>
Expand Down