Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/datepicker decade picker unclickable #1452

Merged
merged 8 commits into from
Jul 20, 2024
Merged

Fix/datepicker decade picker unclickable #1452

merged 8 commits into from
Jul 20, 2024

Commits on Jul 20, 2024

  1. fix(ui): DatePicker years title correct range 

    - Range of years presented in title now match the calendar for
the year view
- Removed unnecessary subtraction and multiplication in year
 view
    Marcus Gilmore-Lim committed Jul 20, 2024
    Configuration menu
    Copy the full SHA
    bc2c216 View commit details
    Browse the repository at this point in the history

  2. fix(ui): DatePicker decades title correct range 

    - Found the date range presented was offset
incorrectly. e.g. the range presented would be 1990-2100 but range presented was 2000-2090
    Marcus Gilmore-Lim committed Jul 20, 2024
    Configuration menu
    Copy the full SHA
    76c65e3 View commit details
    Browse the repository at this point in the history

  3. fix(ui): DatePicker decade isDisabled fixed (themesberg#1211) 

    - Found the use of `isDateInRange` was using the wrong
dates for the date, minDate and maxDate.
- Updated `isDisabled` check to ensure both the first and last
date are in range.
- Minor optimisation as `first` doesn't need to be regenerated
for each decade.
    Marcus Gilmore-Lim committed Jul 20, 2024
    Configuration menu
    Copy the full SHA
    d21bf16 View commit details
    Browse the repository at this point in the history

  4. test(ui): Test for decade title rendering 

    - Testing that decade titles are being rendered correctly (and technically days, years and months)
    Marcus Gilmore-Lim committed Jul 20, 2024
    Configuration menu
    Copy the full SHA
    4a59c42 View commit details
    Browse the repository at this point in the history

  5. test(ui): Datepicker tests when maxDate set 

    - Tested if the button for the earlier decade is enabled when max date is set
Tested if the button for the later decade is disabled when max date is set
    Marcus Gilmore-Lim committed Jul 20, 2024
    Configuration menu
    Copy the full SHA
    c8b52d9 View commit details
    Browse the repository at this point in the history

  6. test(ui): Datepicker tests when minDate set 

    - Tested if the button for the earlier decade is disabled when min date is set
- Tested if the button for the later decade is enabled when min date is set
    Marcus Gilmore-Lim committed Jul 20, 2024
    Configuration menu
    Copy the full SHA
    4e7aa5d View commit details
    Browse the repository at this point in the history

  7. fix(ui): storybook Datepicker default date mistyping 

    - When minDate and maxDate were defined, defaultDate was not updated to a Date.
    Marcus Gilmore-Lim committed Jul 20, 2024
    Configuration menu
    Copy the full SHA
    8042d23 View commit details
    Browse the repository at this point in the history

  8. test(ui): Datepicker tests decade within range 

    - Tested if decades within a maxDate minDate range are correctly selectable.
    Marcus Gilmore-Lim committed Jul 20, 2024
    Configuration menu
    Copy the full SHA
    d2268ce View commit details
    Browse the repository at this point in the history